Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ubuntu from 22.04 to 24.04 #97

Closed
wants to merge 1 commit into from
Closed

Bump ubuntu from 22.04 to 24.04 #97

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024

Bumps ubuntu from 22.04 to 24.04.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump ubuntu from 22.04 to 24.04
1fc1e4e 
Bumps ubuntu from 22.04 to 24.04.

---
updated-dependencies:
- dependency-name: ubuntu
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Apr 29, 2024
@tomeichlersmith tomeichlersmith mentioned this pull request Aug 14, 2024
Open
@tomeichlersmith
Copy link
Member

This is not building because of ROOT.

[ 21%] Building CXX object io/rootpcm/CMakeFiles/RootPcmObjs.dir/src/rootclingIO.cxx.o
In file included from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/base/inc/Rtypes.h:31,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/base/inc/TObject.h:17,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/base/inc/TNamed.h:25,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/meta/inc/TDictionary.h:44,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/meta/inc/TClass.h:23,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/io/rootpcm/src/rootclingIO.cxx:15:
/usr/include/string.h:506:15: error: declaration of 'size_t strlcpy(char*, const char*, size_t) noexcept' has a different exception specifier
  506 | extern size_t strlcpy (char *__restrict __dest,
      |               ^~~~~~~
In file included from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/base/inc/Rtypes.h:27:
/home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/clib/inc/strlcpy.h:26:8: note: from previous declaration 'size_t strlcpy(char*, const char*, size_t)'
   26 | size_t strlcpy(char *dst, const char *src, size_t siz);
      |        ^~~~~~~
/usr/include/string.h:512:15: error: declaration of 'size_t strlcat(char*, const char*, size_t) noexcept' has a different exception specifier
  512 | extern size_t strlcat (char *__restrict __dest,
      |               ^~~~~~~
/home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/clib/inc/strlcpy.h:27:8: note: from previous declaration 'size_t strlcat(char*, const char*, size_t)'
   27 | size_t strlcat(char *dst, const char *src, size_t siz);
      |        ^~~~~~~
In file included from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/base/inc/TUrl.h:29,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/io/io/inc/TFile.h:28,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/io/rootpcm/src/rootclingIO.cxx:18:
/home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/cont/inc/TMap.h:145:30: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
  145 |                  public std::iterator<std::bidirectional_iterator_tag,
      |                              ^~~~~~~~
In file included from /usr/include/c++/13/bits/stl_algobase.h:65,
                 from /usr/include/c++/13/vector:62,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/meta/inc/TGenericClassInfo.h:21,
                 from /home/tom/code/ldmx/docker/dev-home/root-6.22.08/core/base/inc/Rtypes.h:189:
/usr/include/c++/13/bits/stl_iterator_base_types.h:127:34: note: declared here
  127 |     struct _GLIBCXX17_DEPRECATED iterator
      |                                  ^~~~~~~~
gmake[2]: *** [io/rootpcm/CMakeFiles/RootPcmObjs.dir/build.make:76: io/rootpcm/CMakeFiles/RootPcmObjs.dir/src/rootclingIO.cxx.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:19666: io/rootpcm/CMakeFiles/RootPcmObjs.dir/all] Error 2
gmake: *** [Makefile:156: all] Error 2

This looks deep enough within ROOT to me that I think we should update ROOT when we want to update OS versions. I've attached the full patch file showing what I did to the Dockerfile when replicating the build failing on CI.

For this reason, I am closing this PR and plan to delay the update until Ubuntu 26. Ubuntu 22 (what we have now) will be supported until April 2027 a year after the planned Ubuntu 26 release.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 14, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/docker/ubuntu-24.04 branch August 14, 2024 17:17
@tvami tvami mentioned this pull request Aug 20, 2024
Merged
2 tasks
@tomeichlersmith tomeichlersmith mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomeichlersmith